Ramon Nou authored Oct 01, 2020 and Ramon Nou committed Jun 16, 2021

Moved distributor instantation to RPC_DATA and daemon.cpp on the server side. Added interval_map to GuidedDistributor for better performance

Moving reads extended log to normal log module.

Update logging.hpp

Added GKFS prefix to CMake options

Catch2 Guided Distributor test

Added creation of /tmp/guided.txt in the test

updated README.MD and protected Distributor for duplicated inserts

Added metadata + data optimization with #

- more error handling
- removed runtime exception from client
- Streamlining error handling in client and making it consistent. Adding comments
- Improved readdir logging

Marc Vef authored Feb 25, 2020 and Alberto Miranda committed Jul 28, 2020

The `ChunkStorage` backend class on the daemon was throwing `system_errors` without being caught, crashing the server in the process. `ChunkStorage` now uses a designated error class for errors that might occur. In addition the dependency to Argobots was removed which was used to trigger `ABT_eventuals`, laying ground work for future non-Argobots IO implementations. Further, the whole class was refactored for consistency and failure resistance.

A new class `ChunkOperation` is introduced which wraps Argobots' IO task operations which allows the removal of IO queue specific code within RPC handlers, i.e., read and write handlers. The idea is to separate eventuals, tasks and their arguments from handler logic into a designated class. Therefore, an object of an inherited class of `ChunkOperation` is instantiated within the handlers that drives all IO tasks. The corresponding code was added to the read and write RPC handlers. Note, `ChunkOperation` is not thread-safe and is supposed to be called by a single thread.

In addition, truncate was reworked for error handling (it crashed the server on error) and that it uses the IO queue as well since truncate causes a write operation and should not overtake IO tasks in the queue.

The chunk stat rpc handler was refactored for error handling and to use error codes as well. 

Further minor changes:
- dead chunk stat code has been removed
- some namespaces were missing: `gkfs::rpc`
- more flexible handler cleanup and response code
- fixed a bug where the chunk dir wasn't removed when the metadata didn't exist on the same node

to avoid name clash with rpc types

Reformatted code w.r.t. unifying code styles as of the official
CPPCoreGuidelines by Stroustrup and Sutter

Restructuring code w.r.t. configurations and definitions:
- #defines have been mostly removed from configurations
- a dedicated config file has been added for configurations with constexpr
- past configure file is now only a cmake wrapper
- wrapping global functions into namespaces

Removed all adafs and ifs occurrences. Now called gkfs

Write errors happenig on deamons are now reported back to clients.
"No space left on device" error is now properly propagated to clients.