Resolve "Refactor RPC implementation of `admire::register_pfs_storage`"

This MR moves the implementation of the RPC construction for ADM_register_pfs_storage to admire::detail in impl.[ch]pp similarly to other RPCs already refactored. This includes changing the C ADM_types to native C++ types.

Closes #99 (closed)

examples/c/ADM_register_pfs_storage.c

@@ -25,11 +25,6 @@
 #include <stdlib.h>
 #include <stdio.h>
 #include <admire.h>
-#include <assert.h>
-#include "common.h"
-
-#define NINPUTS  10
-#define NOUTPUTS 5
 
 int
 main(int argc, char* argv[]) {
@@ -41,28 +36,60 @@ main(int argc, char* argv[]) {
     }
 
     int exit_status = EXIT_SUCCESS;
-    ADM_server_t server = ADM_server_create("tcp", argv[1]);
+    ADM_return_t ret = ADM_SUCCESS;
+    ADM_server_t server = NULL;
+
+    // pfs information
+    const char* pfs_name = "gpfs_scratch";
+    const char* pfs_mount = "/gpfs/scratch";
+    ADM_pfs_context_t pfs_ctx = NULL;
+    ADM_pfs_storage_t pfs_storage = NULL;
 
-    ADM_pfs_storage_t pfs_storage;
+    // Let's prepare all the information required by the API calls.
+    // ADM_register_pfs_storage() requires a set of nodes for the PFS
+    // storage to use and an appropriate execution context defining how it
+    // should behave:
 
-    ADM_pfs_context_t ctx = ADM_pfs_context_create("/gpfs");
-    assert(ctx);
+    // 1. define the PFS execution context
+    pfs_ctx = ADM_pfs_context_create(pfs_mount);
 
-    ADM_return_t ret = ADM_register_pfs_storage(server, ctx, &pfs_storage);
+    if(pfs_ctx == NULL) {
+        fprintf(stderr, "Fatal error preparing PFS context\n");
+        goto cleanup;
+    }
+
+    // All the information required by the ADM_register_pfs_storage() API is
+    // now ready. Let's actually contact the server:
+
+    // 1. Find the server endpoint
+    if((server = ADM_server_create("tcp", argv[1])) == NULL) {
+        fprintf(stderr, "Fatal error creating server\n");
+        goto cleanup;
+    }
 
-    if(ret != ADM_SUCCESS) {
-        fprintf(stderr,
-                "ADM_register_pfs_storage() remote procedure not completed "
-                "successfully: %s\n",
+    // 2. Register the adhoc storage
+    if(ADM_register_pfs_storage(server, pfs_name, ADM_PFS_STORAGE_GPFS, pfs_ctx,
+                                &pfs_storage) != ADM_SUCCESS) {
+        fprintf(stderr, "ADM_register_pfs_storage() failed: %s\n",
                 ADM_strerror(ret));
-        exit_status = EXIT_FAILURE;
         goto cleanup;
     }
 
-    fprintf(stdout, "ADM_register_pfs_storage() remote procedure completed "
-                    "successfully\n");
+    // The PFS storage is now registered into the system :)
+    exit_status = EXIT_SUCCESS;
+
+    // Once the PFS storage is no longer required we need to notify the server
+    if((ret = ADM_remove_pfs_storage(server, pfs_storage)) != ADM_SUCCESS) {
+        fprintf(stderr, "ADM_remove_pfs_storage() failed: %s\n",
+                ADM_strerror(ret));
+        pfs_storage = NULL;
+        exit_status = EXIT_FAILURE;
+        // intentionally fall through...
+    }
 
 cleanup:
     ADM_server_destroy(server);
+    ADM_pfs_context_destroy(pfs_ctx);
+
     exit(exit_status);
 }