Resolve "Compiling in Release disables asserts, making variables unused (Werror)"

This MR fixes several build errors that only appeared on Release builds.

It also adds a new build_release job to the CI pipelines to exercise a build in Release mode.

Closes #58 (closed)

.gitlab-ci.yml

@@ -6,7 +6,27 @@ stages:
   - build
   - test
 
-build:
+release_build:
+  stage: build
+  script:
+    - export LD_LIBRARY_PATH=/usr/local/lib:/usr/local/lib64
+    - export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/usr/local/lib64/pkgconfig
+    - mkdir -p build
+    - cd build
+    - cmake
+      -DCMAKE_BUILD_TYPE:STRING=Release
+      -DCMAKE_PREFIX_PATH:STRING=/usr/local
+      -DCMAKE_INSTALL_PREFIX:STRING=${CI_PROJECT_DIR}/compiled
+      -DSCORD_BUILD_EXAMPLES:BOOL=ON
+      -DSCORD_BUILD_TESTS:BOOL=ON
+      -DSCORD_TRANSPORT_LIBRARY=libfabric
+      -DSCORD_TRANSPORT_PROTOCOL=ofi+tcp
+      -DSCORD_BIND_ADDRESS=127.0.0.1
+      -DSCORD_BIND_PORT=52000
+      ..
+    - make -j$(nproc) install
+
+debug_build:
   stage: build
   script:
     - export LD_LIBRARY_PATH=/usr/local/lib:/usr/local/lib64
@@ -45,7 +65,7 @@ build:
 # run RPC tests using the binary built before
 rpc:
   stage: test
-  needs: [build]
+  needs: [debug_build]
   script:
     - export ASAN_OPTIONS=detect_odr_violation=0:detect_leaks=0
     - export LSAN_OPTIONS=verbosity=1:log_threads=1:suppressions=${CI_PROJECT_DIR}/tests/LSanSuppress.supp
@@ -62,7 +82,7 @@ rpc:
 # run unit tests
 unit:
   stage: test
-  needs: [build]
+  needs: [debug_build]
   script:
     - export ASAN_OPTIONS=detect_odr_violation=0
     - export LSAN_OPTIONS=verbosity=1:log_threads=1:suppressions=${CI_PROJECT_DIR}/tests/LSanSuppress.supp