Skip to content
Snippets Groups Projects
Commit 4308a673 authored by Alberto Miranda's avatar Alberto Miranda :hotsprings:
Browse files

Merge branch 'amiranda/74-server_id-should-not-be-optional-in-adhoc_storage' into 'main'

Resolve "server_id should not be optional in adhoc_storage"

This MR makes the `server_id` member in adhoc_storage explicit. The rationale
is that constructors (for the C++ API) or `.*_create()` functions (for the C API)
will most of the time be called from internal code, since client code will rely
mostly on `ADM_register_.*()` to obtain handlers.

In this scenario, there's no possibility for the `server_id` "to not having been 
assigned yet", which is why it was `optional` in the first place.

Also, this MR renames the `user_id` to `name`, and the `server_id` to `id`.

Closes #74 #75

See merge request !51
parents c204fc30 13c5f9cb
No related branches found
No related tags found
1 merge request!51Resolve "server_id should not be optional in adhoc_storage"
Pipeline #3219 passed
Showing
with 40 additions and 40 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment