Skip to content
Commit fd8328be authored by Al Viro's avatar Al Viro
Browse files

[PATCH] sanitize handling of shared descriptor tables in failing execve()



* unshare_files() can fail; doing it after irreversible actions is wrong
  and de_thread() is certainly irreversible.
* since we do it unconditionally anyway, we might as well do it in do_execve()
  and save ourselves the PITA in binfmt handlers, etc.
* while we are at it, binfmt_som actually leaked files_struct on failure.

As a side benefit, unshare_files(), put_files_struct() and reset_files_struct()
become unexported.

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 6b335d9c
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment