Skip to content
Commit b32d1310 authored by David S. Miller's avatar David S. Miller
Browse files

tcp: Fix bitmask test in tcp_syn_options()



As reported by Alexey Dobriyan:

	  CHECK   net/ipv4/tcp_output.c
	net/ipv4/tcp_output.c:475:7: warning: dubious: !x & y

And sparse is damn right!

	if (unlikely(!OPTION_TS & opts->options))
		    ^^^
		size += TCPOLEN_SACKPERM_ALIGNED;

OPTION_TS is (1 << 1), so condition will never trigger.

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ebb36a97
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment