Skip to content
Commit aedb60a6 authored by Serge Hallyn's avatar Serge Hallyn Committed by Linus Torvalds
Browse files

file capabilities: remove cap_task_kill()



The original justification for cap_task_kill() was as follows:

	check_kill_permission() does appropriate uid equivalence checks.
	However with file capabilities it becomes possible for an
	unprivileged user to execute a file with file capabilities
	resulting in a more privileged task with the same uid.

However now that cap_task_kill() always returns 0 (permission
granted) when p->uid==current->uid, the whole hook is worthless,
and only likely to create more subtle problems in the corner cases
where it might still be called but return -EPERM.  Those cases
are basically when uids are different but euid/suid is equivalent
as per the check in check_kill_permission().

One example of a still-broken application is 'at' for non-root users.

This patch removes cap_task_kill().

Signed-off-by: default avatarSerge Hallyn <serge@hallyn.com>
Acked-by: default avatarAndrew G. Morgan <morgan@kernel.org>
Earlier-version-tested-by: default avatarLuiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>
Acked-by: default avatarCasey Schaufler <casey@schaufler-ca.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 457fb605
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment