Skip to content
Commit 93b83aac authored by James Bottomley's avatar James Bottomley Committed by Herton Ronaldo Krzesinski
Browse files

Fix oops caused by queue refcounting failure



BugLink: http://bugs.launchpad.net/bugs/802383

commit e73e079bf128d68284efedeba1fbbc18d78610f9 upstream.

In certain circumstances, we can get an oops from a torn down device.
Most notably this is from CD roms trying to call scsi_ioctl.  The root
cause of the problem is the fact that after scsi_remove_device() has
been called, the queue is fully torn down.  This is actually wrong
since the queue can be used until the sdev release function is called.
Therefore, we add an extra reference to the queue which is released in
sdev->release, so the queue always exists.

Reported-by: default avatarParag Warudkar <parag.lkml@gmail.com>
Signed-off-by: default avatarJames Bottomley <jbottomley@parallels.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: default avatarTim Gardner <tim.gardner@canonical.com>
parent ea0770b8
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment