Skip to content
Commit 77dc2db6 authored by Mark Assad's avatar Mark Assad Committed by Linus Torvalds
Browse files

[PATCH] itmtouch: fix inverted flag to indicate touch location correctly, correct white space



There is a bug in the current version of the itmtouch USB touchscreen
driver.  The if statment that checks if pressure is being applied to the
touch screen is now missing a ! (not), so events are no longer being
reported correctly.

The original source code for this line was as follows:

	#define UCP(x) ((unsigned char*)(x))
	#define UCOM(x,y,z) ((UCP((x)->transfer_buffer)[y]) & (z))

	...
	if (!UCOM(urb, 7, 0x20)) {

And was cleaned to:

	unsigned char *data = urb->transfer_buffer;
	....
	 if (data[7] & 0x20) {

(note the lack of '!')

This has been tested on an LG L1510BF and an LG1510SF touch screen.

Signed-off-by: default avatarMark Assad <massad@gmail.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 4b844718
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment