Skip to content
Commit 552b8aa4 authored by Ingo Molnar's avatar Ingo Molnar
Browse files

Revert "x86: signal: change type of paramter for sys_rt_sigreturn()"

This reverts commit 4217458d

.

Justin Madru bisected this commit, it was causing weird Firefox
crashes.

The reason is that GCC mis-optimizes (re-uses) the on-stack parameters of
the calling frame, which corrupts the syscall return pt_regs state and
thus corrupts user-space register state.

So we go back to the slightly less clean but more optimization-safe
method of getting to pt_regs. Also add a comment to explain this.

Resolves: http://bugzilla.kernel.org/show_bug.cgi?id=12505

Reported-and-bisected-by: default avatarJustin Madru <jdm64@gawab.com>
Tested-by: default avatarJustin Madru <jdm64@gawab.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent e0a96129
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment