chunk remove test

Ramon Nourequested to merge
rnou/chunkremovetest into master

added test, and CREATE_EXIST_CHECK env

Merge request reports

docs/sphinx/devs/coverage.md

+1 −1
Changes for docs/sphinx/devs/coverage.md: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -51,7 +51,7 @@ Preset CMake variables: 


  CMAKE_BUILD_TYPE="Coverage"

  CMAKE_CXX_COMPILER="/usr/bin/g++"

  CMAKE_CXX_FLAGS="-Wall -Wextra -fdiagnostics-color=always --pedantic -Wno-unused-parameter -Wno-missing-field-initializers -DGKFS_DEBUG_BUILD -DHERMES_DEBUG_BUILD"

  CMAKE_CXX_FLAGS="-Wall -Wextra -fdiagnostics-color=always --pedantic -Wno-unused-parameter -Wno-missing-field-initializers -DGKFS_DEBUG_BUILD"

  CMAKE_CXX_FLAGS_COVERAGE="-Og -g --coverage -fkeep-static-functions"

  CMAKE_C_COMPILER="/usr/bin/gcc"

  CMAKE_C_FLAGS_COVERAGE="-Og -g --coverage -fkeep-static-functions"

hermes @ 072c0332

Compare 072c0332 to 072c0332
Changes for external/hermes: 0 added lines, 1 removed line.
Original line number Diff line number Diff line 
Subproject commit 072c033225057aefdbdcc852ba0a360706668800

include/client/logging.hpp

+3 −16
Changes for include/client/logging.hpp: 3 added lines, 16 removed lines.
Original line number Diff line number Diff line
@@ -65,7 +65,6 @@ enum class log_level : unsigned int { 
    print_critical = 1 << 3,

    print_errors = 1 << 4,

    print_warnings = 1 << 5,

    print_hermes = 1 << 6,

    print_mercury = 1 << 7,

    print_debug = 1 << 8,

    print_trace_reads = 1 << 9,
@@ -73,8 +72,8 @@ enum class log_level : unsigned int { 
    // for internal use

    print_none = 0,

    print_all = print_syscalls | print_syscalls_entry | print_info |

                print_critical | print_errors | print_warnings | print_hermes |

                print_mercury | print_debug,

                print_critical | print_errors | print_warnings | print_mercury |

                print_debug,

    print_most = print_all & ~print_syscalls_entry,

    print_help = 1 << 10

};
@@ -126,7 +125,6 @@ static const auto constexpr info = log_level::print_info; 
static const auto constexpr critical = log_level::print_critical;

static const auto constexpr error = log_level::print_errors;

static const auto constexpr warning = log_level::print_warnings;

static const auto constexpr hermes = log_level::print_hermes;

static const auto constexpr mercury = log_level::print_mercury;

static const auto constexpr debug = log_level::print_debug;

static const auto constexpr trace_reads = log_level::print_trace_reads;
@@ -138,7 +136,7 @@ static const auto constexpr help = log_level::print_help; 
static const auto constexpr level_names = utils::make_array(

        "syscall",

        "syscall", // sycall_entry uses the same name as syscall

        "info", "critical", "error", "warning", "hermes", "mercury", "debug",

        "info", "critical", "error", "warning", "mercury", "debug",

        "trace_reads");



inline constexpr auto
@@ -582,9 +580,6 @@ destroy_global_logger() { 
#define LOG_CRITICAL(...)                                                      \

    do {                                                                       \

    } while(0);

#define LOG_HERMES(...)                                                        \

    do {                                                                       \

    } while(0);

#define LOG_MERCURY(...)                                                       \

    do {                                                                       \

    } while(0);
@@ -632,14 +627,6 @@ destroy_global_logger() { 
        }                                                                      \

    } while(0);



#define LOG_HERMES(...)                                                        \

    do {                                                                       \

        if(gkfs::log::get_global_logger()) {                                   \

            gkfs::log::get_global_logger()->log(gkfs::log::hermes, __func__,   \

                                                __LINE__, __VA_ARGS__);        \

        }                                                                      \

    } while(0);



#define LOG_MERCURY(...)                                                       \

    do {                                                                       \

        if(gkfs::log::get_global_logger()) {                                   \

include/daemon/env.hpp

+2 −0
Changes for include/daemon/env.hpp: 2 added lines, 0 removed lines.
Original line number Diff line number Diff line
@@ -56,6 +56,8 @@ static constexpr auto USE_DIRENTS_COMPRESSION = 
static constexpr auto HOSTS_FILE = ADD_PREFIX("HOSTS_FILE");

static constexpr auto DAEMON_CREATE_CHECK_PARENTS =

        ADD_PREFIX("DAEMON_CREATE_CHECK_PARENTS");

static constexpr auto DAEMON_CREATE_EXIST_CHECK =

        ADD_PREFIX("DAEMON_CREATE_EXIST_CHECK");

static constexpr auto DAEMON_SYMLINK_SUPPORT =

        ADD_PREFIX("DAEMON_SYMLINK_SUPPORT");

static constexpr auto DAEMON_RENAME_SUPPORT =

include/config.hpp

+1 −1
Changes for include/config.hpp: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -129,7 +129,7 @@ constexpr auto implicit_data_removal = true; 
// metadata logic

// Check for existence of file metadata before create. This done on RocksDB

// level

constexpr auto create_exist_check = true;

inline bool create_exist_check = true;

// Verify that a parent directory exists before creating new files or

// directories

inline bool create_check_parents = true;