Commit e9a691e3 authored by Julius Athenstaedt's avatar Julius Athenstaedt
Browse files

GKFS_ prefix for CLIENT_LOG_MESSAGE_SIZE

parent 39840ca1

.gitignore

+1 −0
Original line number Diff line number Diff line
@@ -68,6 +68,7 @@ 


# clangd

.clangd

.cache



# OS generated files

.DS_Store

CMake/gkfs-options.cmake

+1 −5
Original line number Diff line number Diff line
@@ -264,13 +264,11 @@ gkfs_define_option( 
################################################################################



## Maximum number of internal file descriptors reserved for GekkoFS

# FIXME: should be prefixed with GKFS_

gkfs_define_variable(GKFS_MAX_INTERNAL_FDS 256

  STRING "Number of file descriptors reserved for internal use" ADVANCED

)



## Maximum number of open file descriptors for GekkoFS

# FIXME: should be prefixed with GKFS_

execute_process(COMMAND getconf OPEN_MAX

  OUTPUT_VARIABLE _GETCONF_MAX_FDS

  OUTPUT_STRIP_TRAILING_WHITESPACE
@@ -324,15 +322,13 @@ gkfs_define_option( 
################################################################################



## Client logging support

# FIXME: should be prefixed with GKFS_

gkfs_define_option(

  GKFS_ENABLE_CLIENT_LOG HELP_TEXT "Enable logging messages in clients"

  DEFAULT_VALUE ON

)



# FIXME: should be prefixed with GKFS_

gkfs_define_variable(

  CLIENT_LOG_MESSAGE_SIZE

  GKFS_CLIENT_LOG_MESSAGE_SIZE

  1024

  STRING

  "Maximum size of a log message in the client library"

CMakeLists.txt

+2 −2
Original line number Diff line number Diff line
@@ -276,7 +276,7 @@ endif() 


if(GKFS_ENABLE_CLIENT_LOG)

    add_definitions(-DGKFS_ENABLE_LOGGING)

    add_definitions(-DLIBGKFS_LOG_MESSAGE_SIZE=${CLIENT_LOG_MESSAGE_SIZE})

    add_definitions(-DLIBGKFS_LOG_MESSAGE_SIZE=${GKFS_CLIENT_LOG_MESSAGE_SIZE})

endif ()



if(GKFS_ENABLE_UNUSED_FUNCTIONS)

CMakePresets.json

+1 −1
Original line number Diff line number Diff line
@@ -19,7 +19,7 @@ 
        "GKFS_BUILD_TESTS": false,

        "GKFS_INSTALL_TESTS": false,

        "GKFS_ENABLE_CLIENT_LOG": true,

        "CLIENT_LOG_MESSAGE_SIZE": "1024",

        "GKFS_CLIENT_LOG_MESSAGE_SIZE": "1024",

        "GKFS_SYMLINK_SUPPORT": false

      },

      "warnings": {

docs/sphinx/devs/coverage.md

+1 −1
Original line number Diff line number Diff line
@@ -49,7 +49,6 @@ that greatly simplify this process. Thus, GekkoFS provides a CMake 
$ cmake --preset=default-coverage

Preset CMake variables:



  CLIENT_LOG_MESSAGE_SIZE="512"

  CMAKE_BUILD_TYPE="Coverage"

  CMAKE_CXX_COMPILER="/usr/bin/g++"

  CMAKE_CXX_FLAGS="-Wall -Wextra -fdiagnostics-color=always --pedantic -Wno-unused-parameter -Wno-missing-field-initializers -DGKFS_DEBUG_BUILD -DHERMES_DEBUG_BUILD"
@@ -59,6 +58,7 @@ Preset CMake variables: 
  CMAKE_EXE_LINKER_FLAGS_COVERAGE="--coverage"

  CMAKE_MAP_IMPORTED_CONFIG_COVERAGE="Coverage;RelWithDebInfo;Release;Debug;"

  CMAKE_SHARED_LINKER_FLAGS_COVERAGE="--coverage"

  GKFS_CLIENT_LOG_MESSAGE_SIZE="512"

  GKFS_ENABLE_CLIENT_LOG:BOOL="TRUE"

  GKFS_BUILD_DOCUMENTATION:BOOL="TRUE"

  GKFS_BUILD_TESTS:BOOL="TRUE"