Commit c81a9591 authored by Ramon Nou's avatar Ramon Nou
Browse files

Merge branch 'jathenst/280-hooks-narrow-cast-types' into 'master' 

Resolve "Hooks narrow cast types"

Closes #280

Closes #280

See merge request !182
parents e7751d13 3c95f4e7

.gitmodules

+3 −0
Original line number Diff line number Diff line
@@ -25,3 +25,6 @@ 
[submodule "external/MessagePack"]

	path = external/MessagePack

	url = https://github.com/GekkoFS/MessagePackCPP.git

[submodule "external/GSL"]

	path = external/GSL

	url = https://github.com/microsoft/GSL

CHANGELOG.md

+2 −0
Original line number Diff line number Diff line
@@ -87,6 +87,8 @@ replicas ([!166](https://storage.bsc.es/gitlab/hpc/gekkofs/-/merge_requests/141) 


### New



- Use of GSL to narrow cast syscall return types, corrected syscall return types 

  ([!182](https://storage.bsc.es/gitlab/hpc/gekkofs/-/merge_requests/182)).

- Support for client-side per process logging, activated

  with `LIBGKFS_LOG_PER_PROCESS` ([!179](https://storage.bsc.es/gitlab/hpc/gekkofs/-/merge_requests/179)).

- Support mtime with option gkfs::config::metadata::

CMakeLists.txt

+8 −0
Original line number Diff line number Diff line
@@ -261,6 +261,14 @@ if (GKFS_ENABLE_CLIENT_METRICS) 
    )

endif ()



### GSL: Guidelines Support Library

include_from_source(gsl

	MESSAGE "[${PROJECT_NAME}] Searching for GSL"

	SOURCE_DIR ${GKFS_DEPENDENCIES_PATH}/GSL

  GIT_REPOSITORY https://github.com/microsoft/GSL

  GIT_TAG v4.0.0

)



################################################################################

## Check configured variables/options and act accordingly

################################################################################

GSL @ a3534567

Original line number Diff line number Diff line 
Subproject commit a3534567187d2edc428efd3f13466ff75fe5805c

include/client/hooks.hpp

+12 −12
Original line number Diff line number Diff line
@@ -94,29 +94,29 @@ hook_fstat(unsigned int fd, struct stat* buf); 
int

hook_fstatat(int dirfd, const char* cpath, struct stat* buf, int flags);



int

ssize_t

hook_read(unsigned int fd, void* buf, size_t count);



int

ssize_t

hook_pread(unsigned int fd, char* buf, size_t count, loff_t pos);



int

ssize_t

hook_readv(unsigned long fd, const struct iovec* iov, unsigned long iovcnt);



int

ssize_t

hook_preadv(unsigned long fd, const struct iovec* iov, unsigned long iovcnt,

            unsigned long pos_l, unsigned long pos_h);



int

ssize_t

hook_write(unsigned int fd, const char* buf, size_t count);



int

ssize_t

hook_pwrite(unsigned int fd, const char* buf, size_t count, loff_t pos);



int

ssize_t

hook_writev(unsigned long fd, const struct iovec* iov, unsigned long iovcnt);



int

ssize_t

hook_pwritev(unsigned long fd, const struct iovec* iov, unsigned long iovcnt,

             unsigned long pos_l, unsigned long pos_h);
@@ -158,10 +158,10 @@ hook_dup2(unsigned int oldfd, unsigned int newfd); 
int

hook_dup3(unsigned int oldfd, unsigned int newfd, int flags);



int

long

hook_getdents(unsigned int fd, struct linux_dirent* dirp, unsigned int count);



int

ssize_t

hook_getdents64(unsigned int fd, struct linux_dirent64* dirp,

                unsigned int count);
@@ -183,7 +183,7 @@ hook_fchdir(unsigned int fd); 
int

hook_getcwd(char* buf, unsigned long size);



int

ssize_t

hook_readlinkat(int dirfd, const char* cpath, char* buf, int bufsiz);



int
@@ -202,7 +202,7 @@ hook_fstatfs(unsigned int fd, struct statfs* buf); 
int

hook_fsync(unsigned int fd);



int

ssize_t

hook_getxattr(const char* path, const char* name, void* value, size_t size);



int