Unverified Commit 8c7c6f53 authored by Tommaso Tocci's avatar Tommaso Tocci
Browse files

Cleanup get_fs_config RPC

parent 0ffc4a3f

src/client/rpc/ld_rpc_management.cpp

+6 −6
Original line number Original line Diff line number Diff line
@@ -43,16 +43,16 @@ bool get_fs_config() { 
        CTX->log()->error("{}() creating handle for failed", __func__);

        CTX->log()->error("{}() creating handle for failed", __func__);

        return false;

        return false;

    }

    }

    CTX->log()->debug("{}() About to send get config RPC to daemon", __func__);

    CTX->log()->debug("{}() Forwarding request", __func__);

    int send_ret = HG_FALSE;

    for (int i = 0; i < RPC_TRIES; ++i) {

    for (int i = 0; i < RPC_TRIES; ++i) {

        send_ret = margo_forward_timed(handle, &in, RPC_TIMEOUT);

        ret = margo_forward_timed(handle, &in, RPC_TIMEOUT);

        if (send_ret == HG_SUCCESS) {

        if (ret == HG_SUCCESS) {

            break;

            break;

        }

        }

        CTX->log()->warn("{}() Failed to forward request. Error: {}. Attempt {}/{}", __func__, HG_Error_to_string(ret), i+1, RPC_TRIES);

    }

    }

    if (send_ret != HG_SUCCESS) {

    if (ret != HG_SUCCESS) {

        CTX->log()->warn("{}() timed out", __func__);

        CTX->log()->error("{}() Failed to forward request. Giving up after {} attempts", __func__, RPC_TRIES);

        margo_destroy(handle);

        margo_destroy(handle);

        return false;

        return false;

    }

    }