Unverified Commit 60b1a186 authored by Tommaso Tocci's avatar Tommaso Tocci
Browse files

Drop access RPC 

The access RPC have been removed. The POSIX access functionality now is implemented through the stat RPC. This makes code easier to maintain and modify.

There would be a little performance degradation on the POSIX access
function because we are now retrieving also the metadata
associated to the file.

This change makes a lot easier to add symlink support
parent 27a02ce3

include/client/preload_util.hpp

+0 −1
Original line number Diff line number Diff line
@@ -31,7 +31,6 @@ extern margo_instance_id ld_margo_rpc_id; 
extern hg_id_t rpc_config_id;

extern hg_id_t rpc_mk_node_id;

extern hg_id_t rpc_stat_id;

extern hg_id_t rpc_access_id;

extern hg_id_t rpc_rm_node_id;

extern hg_id_t rpc_decr_size_id;

extern hg_id_t rpc_update_metadentry_id;

include/client/rpc/ld_rpc_metadentry.hpp

+0 −2
Original line number Diff line number Diff line
@@ -14,8 +14,6 @@ namespace rpc_send { 


int mk_node(const std::string& path, mode_t mode);



int access(const std::string& path, int mask);



int stat(const std::string& path, std::string& attr);



int rm_node(const std::string& path, const bool remove_metadentry_only);

include/daemon/adafs_ops/metadentry.hpp

+0 −2
Original line number Diff line number Diff line
@@ -21,8 +21,6 @@ void update_metadentry_size(const std::string& path, size_t io_size, off_t offse 


void update_metadentry(const std::string& path, Metadata& md);



int check_access_mask(const std::string& path, int mask);



std::vector<std::pair<std::string, bool>> get_dirents(const std::string& dir);



#endif //IFS_METADENTRY_HPP

include/daemon/handler/rpc_defs.hpp

+0 −2
Original line number Diff line number Diff line
@@ -12,8 +12,6 @@ DECLARE_MARGO_RPC_HANDLER(rpc_srv_fs_config) 


DECLARE_MARGO_RPC_HANDLER(rpc_srv_mk_node)



DECLARE_MARGO_RPC_HANDLER(rpc_srv_access)



DECLARE_MARGO_RPC_HANDLER(rpc_srv_stat)



DECLARE_MARGO_RPC_HANDLER(rpc_srv_decr_size)

include/global/global_defs.hpp

+0 −1
Original line number Diff line number Diff line
@@ -7,7 +7,6 @@ 
namespace hg_tag {

    constexpr auto fs_config = "rpc_srv_fs_config";

    constexpr auto create = "rpc_srv_mk_node";

    constexpr auto access = "rpc_srv_access";

    constexpr auto stat = "rpc_srv_stat";

    constexpr auto remove = "rpc_srv_rm_node";

    constexpr auto decr_size = "rpc_srv_decr_size";