Commit 4f16eb71 authored by Marc Vef's avatar Marc Vef
Browse files

Review before merge. Minor changes.

parent b45e7f0a

CHANGELOG.md

+4 −3
Original line number Diff line number Diff line
@@ -9,9 +9,10 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). 


### New



- Support mtime with option gkfs::config::metadata::use_mtime ([!225](https://storage.bsc.es/gitlab/hpc/gekkofs/-/issues/225))

- Unify -d and -p flags in scripts/compile_dep.sh and dl_dep.sh  ([!188](https://storage.bsc.es/gitlab/hpc/gekkofs/-/issues/188)).

- Logfile per process for the client, activated with LIBGKFS_LOG_PER_PROCESS ([!278](https://storage.bsc.es/gitlab/hpc/gekkofs/-/issues/278)).

- Support for client-side per process logging, activated

  with `LIBGKFS_LOG_PER_PROCESS` ([!179](https://storage.bsc.es/gitlab/hpc/gekkofs/-/merge_requests/179)).

- Support mtime with option gkfs::config::metadata::

  use_mtime ([!178](https://storage.bsc.es/gitlab/hpc/gekkofs/-/merge_requests/178))

- Additional tests to increase code coverage ([!141](https://storage.bsc.es/gitlab/hpc/gekkofs/-/merge_requests/141)).

- GKFS_ENABLE_UNUSED_FUNCTIONS added to disable code to increase code

  coverage. ([!141](https://storage.bsc.es/gitlab/hpc/gekkofs/-/merge_requests/141)).

README.md

+2 −2
Original line number Diff line number Diff line
@@ -200,8 +200,8 @@ usage: gkfs [-h/--help] [-r/--rootdir <path>] [-m/--mountdir <path>] [-a/--args 
The following environment variables can be used to enable logging in the client library: `LIBGKFS_LOG=<module>`

and `LIBGKFS_LOG_OUTPUT=<path/to/file>` to configure the output module and set the path to the log file of the client

library. If not path is specified in `LIBGKFS_LOG_OUTPUT`, the client library will send log messages

to `/tmp/gkfs_client.log`. With `LIBGKFS_LOG_PER_PROCESS=1` it is possible to write separate logs per client process.

If so, the path specified in `LIBGKFS_LOG_OUTPUT` is a directory but should not end with a `/`.

to `/tmp/gkfs_client.log`. Use `LIBGKFS_LOG_PER_PROCESS=ON` to write separate logs per client process.

When enabled, the path specified with `LIBGKFS_LOG_OUTPUT=<path/to/dir>` is used as a directory.



The following modules are available:

docs/sphinx/users/running.md

+2 −2
Original line number Diff line number Diff line
@@ -180,8 +180,8 @@ usage: gkfs [-h/--help] [-r/--rootdir <path>] [-m/--mountdir <path>] [-a/--args 
The following environment variables can be used to enable logging in the client library: `LIBGKFS_LOG=<module>`

and `LIBGKFS_LOG_OUTPUT=<path/to/file>` to configure the output module and set the path to the log file of the client

library. If not path is specified in `LIBGKFS_LOG_OUTPUT`, the client library will send log messages

to `/tmp/gkfs_client.log`. With `LIBGKFS_LOG_PER_PROCESS=1` it is possible to write separate logs per client process.

If so, the path specified in `LIBGKFS_LOG_OUTPUT` is a directory but should not end with a `/`.

to `/tmp/gkfs_client.log`. Use `LIBGKFS_LOG_PER_PROCESS=ON` to write separate logs per client process.

When enabled, the path specified with `LIBGKFS_LOG_OUTPUT=<path/to/dir>` is used as a directory.



The following modules are available:

src/client/logging.cpp

+3 −0
Original line number Diff line number Diff line
@@ -311,6 +311,9 @@ logger::logger(const std::string& opts, const std::string& path, 


        std::string file_path = path;

        if(log_per_process) {

            if(fs::is_regular_file(file_path) && fs::exists(file_path)) {

                fs::remove(file_path);

            }

            fs::create_directories(path);

            file_path = fmt::format("{}/{}", path, log_process_id_);

        }