Resolve "Build with Clang"

Alberto Mirandarequested to merge
amiranda/121-build-with-clang into main

Closes #121 (closed)

Edited by Alberto Miranda

Merge request reports

docker/0.2.0-wip/Dockerfile

+2 −0
Changes for docker/0.2.0-wip/Dockerfile: 2 added lines, 0 removed lines.
Original line number Diff line number Diff line
@@ -15,6 +15,8 @@ RUN apt-get update && \ 
        automake \

        gcc \

        g++ \

        clang \

        libc++-dev \

        procps \

        # AGIOS dependencies

        libconfig-dev \

src/common/abt_cxx/shared_mutex.hpp

+3 −4
Changes for src/common/abt_cxx/shared_mutex.hpp: 3 added lines, 4 removed lines.
Original line number Diff line number Diff line
@@ -25,7 +25,6 @@ 
#include <cassert>

#include <abt.h>

#include <fmt/format.h>

#include <bits/functexcept.h>



#ifndef SCORD_ABT_SHARED_MUTEX_HPP

#define SCORD_ABT_SHARED_MUTEX_HPP
@@ -124,7 +123,7 @@ public: 
    unique_lock() noexcept : m_device(0), m_owns(false) {}



    explicit unique_lock(mutex_type& m)

        : m_device(std::__addressof(m)), m_owns(false) {

        : m_device(std::addressof(m)), m_owns(false) {

        lock();

        m_owns = true;

    }
@@ -235,7 +234,7 @@ public: 
    shared_lock() noexcept : m_device(nullptr), m_owns(false) {}



    explicit shared_lock(mutex_type& m)

        : m_device(std::__addressof(m)), m_owns(true) {

        : m_device(std::addressof(m)), m_owns(true) {

        m.lock_shared();

    }
@@ -288,7 +287,7 @@ public: 
    mutex_type*

    release() noexcept {

        m_owns = false;

        return std::__exchange(m_device, nullptr);

        return std::exchange(m_device, nullptr);

    }



    // Getters

src/common/logger/macros.h

+4 −6
Changes for src/common/logger/macros.h: 4 added lines, 6 removed lines.
Original line number Diff line number Diff line
@@ -133,17 +133,15 @@ 
#define LOGGER_LOG16                 LOGGER_LOGN

#define LOGGER_LOGN(level, fmt, ...) logger_log(level, fmt, __VA_ARGS__)



#define LOGGER_INFO(fmt, ...) LOGGER_LOG(info, fmt __VA_OPT__(, ) __VA_ARGS__);

#define LOGGER_INFO(fmt, ...) LOGGER_LOG(info, fmt, ##__VA_ARGS__);



#ifdef __LOGGER_ENABLE_DEBUG__

#define LOGGER_DEBUG(fmt, ...)                                                 \

    LOGGER_LOG(debug, fmt __VA_OPT__(, ) __VA_ARGS__);

#define LOGGER_DEBUG(fmt, ...) LOGGER_LOG(debug, fmt, ##__VA_ARGS__);

#endif



#define LOGGER_WARN(fmt, ...) LOGGER_LOG(warn, fmt __VA_OPT__(, ) __VA_ARGS__);

#define LOGGER_WARN(fmt, ...) LOGGER_LOG(warn, fmt, ##__VA_ARGS__);



#define LOGGER_ERROR(fmt, ...)                                                 \

    LOGGER_LOG(error, fmt __VA_OPT__(, ) __VA_ARGS__);

#define LOGGER_ERROR(fmt, ...) LOGGER_LOG(error, fmt, ##__VA_ARGS__);



#endif

src/lib/scord/scord.h

+2 −2
Changes for src/lib/scord/scord.h: 2 added lines, 2 removed lines.
Original line number Diff line number Diff line
@@ -401,7 +401,7 @@ ADM_define_data_operation(ADM_server_t server, ADM_job_t job, const char* path, 
ADM_return_t

ADM_connect_data_operation(ADM_server_t server, ADM_job_t job,

                           ADM_dataset_t input, ADM_dataset_t output,

                           bool should_stream, ...);

                           int should_stream, ...);





/**
@@ -441,7 +441,7 @@ ADM_finalize_data_operation(ADM_server_t server, ADM_job_t job, 
ADM_return_t

ADM_link_transfer_to_data_operation(ADM_server_t server, ADM_job_t job,

                                    ADM_data_operation_t op,

                                    ADM_transfer_t transfer, bool should_stream,

                                    ADM_transfer_t transfer, int should_stream,

                                    ...);

src/lib/scord/types.h

+2 −0
Changes for src/lib/scord/types.h: 2 added lines, 0 removed lines.
Original line number Diff line number Diff line
@@ -87,6 +87,7 @@ typedef struct adm_job_resources* ADM_job_resources_t; 
/** I/O stats from a job */

typedef struct {

    // TODO: empty for now

    uint32_t placeholder;

} ADM_job_stats_t;



/** The I/O requirements for a job */
@@ -212,6 +213,7 @@ typedef struct adm_data_operation* ADM_data_operation_t; 
/** A data operation status */

typedef struct {

    // TODO: empty for now

    uint32_t placeholder;

} ADM_data_operation_status_t;