Resolve "adhoc_storage instances should keep track of jobs using them"
This MR associates registered adhoc storage instances with registered jobs.
To do so, it modifies both the job_manager
and the adhoc_storage_manager
classes to store shared_ptr
s to admire::internal::job_info
and
admire::internal::adhoc_storage_info
records. This allows returning the
pointers when checking for information as well as modifying the records in
a synchronized manner.
To keep track of adhoc_storage usage, the new internal adhoc_storage_info
type includes a std::shared_ptr<job_info> m_client
field that models the
association. As of today, an adhoc storage instance can only have a single
job client associated. Trying to add more will result in error.
Closes #85 (closed) #86 (closed) #88 (closed)
Merge request reports
Activity
changed milestone to %ADMIRE mid-term review
added feature in progress labels
assigned to @amiranda
added 6 commits
- d700d29c - types: Create internal_types.hpp
- 254f4702 - job_manager: Store shared_ptr<T> instead of T
- 7c0bf64f - adhoc_storage_manager: Store shared_ptr<T> instead of T
- 4291f4e9 - Keep track of adhoc storage instances client jobs
- 7e9d1bd0 - adhoc_storage: Fix bug with shadowed id
- c5de2913 - examples: Ensure ADM_remove_job is called
Toggle commit listrequested review from @rnou
@rnou: Ready to review!
mentioned in commit 0ccff750