Commit b01ac81f authored by Ramon Nou's avatar Ramon Nou
Browse files

Merge branch '26-hide-implementation-of-api-types-behind-opaque-types' into 'main' 

Resolve "Hide implementation of API types behind opaque types"

This MR implements creation and destruction functions for most library types the fields of which should not be directly accessed by clients.

It also moves the type definitions to their own `types.h` header.

Closes #26

See merge request !17
parents 3efff1ed 6803d913

examples/c/ADM_register_job.c

+2 −2
Original line number Diff line number Diff line
@@ -19,7 +19,7 @@ main(int argc, char* argv[]) { 




    ADM_job_t job;

    ADM_dataset_handle_t inputs[NINPUTS];

    ADM_dataset_t inputs[NINPUTS];



    for(int i = 0; i < NINPUTS; ++i) {

        const char* pattern = "input-dataset-%d";
@@ -29,7 +29,7 @@ main(int argc, char* argv[]) { 
        inputs[i] = ADM_dataset_create(id);

    }



    ADM_dataset_handle_t outputs[NOUTPUTS];

    ADM_dataset_t outputs[NOUTPUTS];



    for(int i = 0; i < NOUTPUTS; ++i) {

        const char* pattern = "output-dataset-%d";

examples/cxx/ADM_cancel_transfer.cpp

+1 −1
Original line number Diff line number Diff line
@@ -15,7 +15,7 @@ main(int argc, char* argv[]) { 
    admire::server server{"tcp", argv[1]};



    ADM_job_t job{};

    ADM_transfer_handle_t tx_handle{};

    ADM_transfer_t tx_handle{};

    ADM_return_t ret = ADM_SUCCESS;



    try {

examples/cxx/ADM_connect_data_operation.cpp

+2 −2
Original line number Diff line number Diff line
@@ -27,8 +27,8 @@ main(int argc, char* argv[]) { 
    admire::server server{"tcp", argv[1]};



    ADM_job_t job{};

    ADM_dataset_handle_t input{};

    ADM_dataset_handle_t output{};

    ADM_dataset_t input{};

    ADM_dataset_t output{};

    bool should_stream = false;

    va_list args; // FIXME placeholder

    ADM_return_t ret = ADM_SUCCESS;

examples/cxx/ADM_define_data_operation.cpp

+1 −1
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ main(int argc, char* argv[]) { 


    ADM_job_t job{};

    const char* path = "";

    ADM_data_operation_handle_t op_handle;

    ADM_data_operation_t op_handle;

    va_list args; // FIXME: placeholder

    ADM_return_t ret = ADM_SUCCESS;

examples/cxx/ADM_deploy_adhoc_storage.cpp

+2 −2
Original line number Diff line number Diff line
@@ -15,11 +15,11 @@ main(int argc, char* argv[]) { 
    admire::server server{"tcp", argv[1]};



    ADM_job_t job{};

    ADM_adhoc_storage_handle_t adhoc_handle{};

    ADM_storage_t adhoc_storage{};

    ADM_return_t ret = ADM_SUCCESS;



    try {

        ret = admire::deploy_adhoc_storage(server, job, adhoc_handle);

        ret = admire::deploy_adhoc_storage(server, job, adhoc_storage);

    } catch(const std::exception& e) {

        fmt::print(stderr, "FATAL: ADM_deploy_adhoc_storage() failed: {}\n",

                   e.what());