Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
S
scord
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
eu
ADMIRE
scord
Commits
67c2160c
Commit
67c2160c
authored
2 years ago
by
Ramon Nou
Browse files
Options
Downloads
Patches
Plain Diff
Missing waitpid return value check
parent
92278242
No related branches found
No related tags found
1 merge request
!40
Resolve "Refactor library RPC implementation of `admire::deploy_adhoc_storage`"
Pipeline
#3374
passed
2 years ago
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/scord/rpc_handlers.cpp
+10
-3
10 additions, 3 deletions
src/scord/rpc_handlers.cpp
with
10 additions
and
3 deletions
src/scord/rpc_handlers.cpp
+
10
−
3
View file @
67c2160c
...
@@ -502,11 +502,18 @@ ADM_deploy_adhoc_storage(hg_handle_t h) {
...
@@ -502,11 +502,18 @@ ADM_deploy_adhoc_storage(hg_handle_t h) {
}
}
default
:
{
default
:
{
int
wstatus
=
0
;
int
wstatus
=
0
;
waitpid
(
pid
,
&
wstatus
,
0
);
pid_t
retwait
=
waitpid
(
pid
,
&
wstatus
,
0
);
if
(
WEXITSTATUS
(
wstatus
)
!=
0
)
{
if
(
retwait
==
-
1
)
{
LOGGER_ERROR
(
"rpc id: {} error_msg:
\"
Error waitpid code: {}
\"
"
,
rpc_id
,
retwait
);
ec
=
admire
::
error_code
::
other
;
ec
=
admire
::
error_code
::
other
;
}
else
{
}
else
{
ec
=
admire
::
error_code
::
success
;
if
(
WEXITSTATUS
(
wstatus
)
!=
0
)
{
ec
=
admire
::
error_code
::
other
;
}
else
{
ec
=
admire
::
error_code
::
success
;
}
}
}
break
;
break
;
}
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment