Commit a63a42d7 authored by David Auer's avatar David Auer
Browse files

Relocation: Document empty directory issue

parent 7accb100
Loading
Loading
Loading
Loading
Loading
+7 −0
Original line number Diff line number Diff line
@@ -176,6 +176,13 @@ transmit_metadata_and_data(gkfs::rpc::host_t localhost) {
            // TODO(dauer) process output
            GKFS_DATA->storage()->remove_chunk(file_path, chunk_id);

            // FIXME This can leave behind empty directories, even when the
            // whole file is delete later. Three possibilities:
            // 1) Clean them up, but make sure this doesn't break another thread
            // creating a new chunk in this directory at the same time.
            // 2) Switch to a flat namespace without directories
            // 3) Ignore and waste some inodes

            if(HG_SUCCESS != gkfs::rpc::margo_client_cleanup(
                                     &handle, &out, &mid, &host_addr, &bulk)) {
                cout << "Error during margo cleanup.\n";