Commit 8fe820ad authored by Alberto Miranda's avatar Alberto Miranda ♨️
Browse files

Merge branch '27-spurious-segfaults-with-libtar' into 'master' 

Resolve "Spurious SEGFAULTs with libtar"

Closes #27

See merge request !11
parents 6236e1fe 637c63fa

.gitlab-ci.yml

+3 −3
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ before_script: 
        protobuf-c-compiler

        libyaml-cpp-dev

        libyaml-dev

        libtar-dev

        libarchive-dev

        cmake



    - pushd . &&
@@ -155,7 +155,7 @@ test:coverage: 
            protobuf-c-compiler

            libyaml-cpp-dev

            libyaml-dev

            libtar-dev

            libarchive-dev

            libcap2-bin

            valgrind

            cmake
@@ -275,7 +275,7 @@ test:optimized: 
            protobuf-c-compiler

            libyaml-cpp-dev

            libyaml-dev

            libtar-dev

            libarchive-dev

            libcap2-bin

            valgrind

            cmake

README.md

+1 −1
Original line number Diff line number Diff line
@@ -65,7 +65,7 @@ $ apt-get install -y libboost-system-dev libboost-filesystem-dev \ 
                     libboost-program-options-dev libboost-thread-dev \

                     libboost-regex-dev libprotobuf-dev protobuf-compiler \

                     libprotobuf-c-dev protobuf-c-compiler \

                     libyaml-cpp-dev libyaml-dev libtar-dev

                     libyaml-cpp-dev libyaml-dev libarchive-dev



# Building and installing libfabric (required for Mercury's OFI/libfabric plugin)

$ git clone https://github.com/ofiwg/libfabric.git &&

configure.ac

+2 −5
Original line number Diff line number Diff line
@@ -149,11 +149,8 @@ AC_SEARCH_LIBS([yaml_parser_initialize], [yaml], 
                AC_SUBST(YAML_LIBS)], 

               [AC_MSG_ERROR([This software requires libyaml >= 0.1.4])])



# check for libtar manually (since it doesn't provide a pkgconfig file)

AC_SEARCH_LIBS([tar_open], [tar],

               [TAR_LIBS="-ltar"

                AC_SUBST(TAR_LIBS)],

               [AC_MSG_ERROR([This software requires libtar >= 1.2.0])])

# check for libarchive

PKG_CHECK_MODULES([LIBARCHIVE], [libarchive >= 3.1.2])



# Checks for header files.

src/Makefile.am

+2 −3
Original line number Diff line number Diff line
@@ -90,7 +90,7 @@ liburd_resources_la_LDFLAGS = \ 
    @BOOST_THREAD_LIB@ \

    @MERCURY_LIBS@ \

	@PROTOBUF_LIBS@ \

	@TAR_LIBS@ \

	@LIBARCHIVE_LIBS@ \

	-pthread
@@ -227,7 +227,7 @@ liburd_aux_la_LDFLAGS = \ 
    @MERCURY_LIBS@ \

	@PROTOBUF_LIBS@ \

	@YAMLCPP_LIBS@ \

	@TAR_LIBS@ \

	@LIBARCHIVE_LIBS@ \

	liburd_resources.la \

	-pthread
@@ -304,7 +304,6 @@ urd_LDFLAGS = \ 
    @BOOST_THREAD_LIB@ \

    @MERCURY_LIBS@ \

	@PROTOBUF_LIBS@ \

	@TAR_LIBS@ \

	liburd_aux.la



# we also need to include it as an additional dependency, since automake

src/urd.cpp

+11 −0
Original line number Diff line number Diff line
@@ -42,6 +42,10 @@ 
#include <string.h>

#include <ctime>



#ifdef __LOGGER_ENABLE_DEBUG__

#include <sys/prctl.h>

#endif



#include <boost/optional.hpp>

#include <boost/optional/optional_io.hpp>

#include <boost/atomic.hpp>
@@ -1528,6 +1532,13 @@ int urd::run() { 
    // validate settings

    check_configuration();



#ifdef __LOGGER_ENABLE_DEBUG__

    if(::prctl(PR_SET_DUMPABLE, 1) != 0) {

        LOGGER_WARN("Failed to set PR_SET_DUMPABLE flag for process. "

                    "Daemon will not produce core dumps.");

    }

#endif



    // daemonize if needed

    if(m_settings->daemonize() && daemonize() != 0) {

        /* parent clean ups and exits, child continues */