From 549bbe41ab4d54519dee64b099caa9d9e1d008b0 Mon Sep 17 00:00:00 2001
From: Ramon Nou <ramon.nou@bsc.es>
Date: Fri, 2 May 2025 11:26:31 +0200
Subject: [PATCH] corrected proxy remove_metadata return (used in remove_data)

---
 CHANGELOG.md                       | 2 +-
 src/proxy/rpc/forward_metadata.cpp | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5ee24b6f8..37fe10b50 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -26,7 +26,7 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 ### Fixed
   - Dup3 is supported if O_CLOEXEC is not used (i.e. hexdump) ([!228](https://storage.bsc.es/gitlab/hpc/gekkofs/-/merge_requests/228))
   - gkfs_do_write uses int instead of ssize_t causing overflow ([!229](https://storage.bsc.es/gitlab/hpc/gekkofs/-/merge_requests/229))
-
+  - proxy remove metadata has inverted return values ([!237](https://storage.bsc.es/gitlab/hpc/gekkofs/-/merge_requests/237))
 
 ## [0.9.4] - 2025-03
 ### New
diff --git a/src/proxy/rpc/forward_metadata.cpp b/src/proxy/rpc/forward_metadata.cpp
index 046180bb0..097f3e4ee 100644
--- a/src/proxy/rpc/forward_metadata.cpp
+++ b/src/proxy/rpc/forward_metadata.cpp
@@ -247,7 +247,7 @@ forward_stat(const std::string& path) {
 
 int
 forward_remove(const std::string& path, bool rm_dir) {
-    auto [err, mode, size] = remove_metadata(path, rm_dir);
+    auto [err, size, mode] = remove_metadata(path, rm_dir);
     if(err != 0) {
         return err;
     }
-- 
GitLab