Improve tests for cp
From @marcvef in !33 (merged):
The current test for
cp
(tests/shell/test_cp.py
) can be improved: I suggest to md5 checksum both files as well. Also due to how we handle chunk sizes, I suggest to test multiple file sizes. For example, multiples of the chunk size (which you currently have with 4MB), 1 file smaller than the chunk size (a few KB), and 1 file larger than the chunk size but not aligning to chunk boundaries (e.g., 2.5MB). I am just not sure if this is the right place for this test.I suggest to add a TODO so that we find out how big a write call is at most with the
cp
command. I would think 4MB is a single write call while a 100MB could cause multiple consecutive smaller writes to the file system.