Verified Commit e2805cd3 authored by Marc Vef's avatar Marc Vef
Browse files

Review: Comments, removed unused code, syntax

parent b78d96a5

README.md

+4 −2
Original line number Diff line number Diff line
@@ -288,8 +288,10 @@ argument `-DGKFS_ENABLE_PROMETHEUS` and the daemon argument `--enable-prometheus 
pushed to the Prometheus instance.



### Rename

`-DRENAME_SUPPORT` allows the application to rename files. This is an experimental feature, and some scenarios may not

work properly. Support for fstat in renamed files is included. 

`-DRENAME_SUPPORT` allows the application to rename files. 

This is an experimental feature, and some scenarios may not work properly. 

Support for fstat in renamed files is included. 



### Acknowledgment



This software was partially supported by the EC H2020 funded NEXTGenIO project (Project ID: 671951, www.nextgenio.eu).

include/client/gkfs_functions.hpp

+3 −4
Original line number Diff line number Diff line
@@ -41,7 +41,7 @@ struct linux_dirent64; 
namespace gkfs::syscall {



int

gkfs_open(const std::string& path, mode_t mode, int flags, bool rename = false);

gkfs_open(const std::string& path, mode_t mode, int flags);



int

gkfs_create(const std::string& path, mode_t mode);
@@ -151,9 +151,8 @@ gkfs_rmdir(const std::string& path); 


#ifdef HAS_RENAME

int

gkfs_rename(const std::string& old_path_resolved,

            const std::string& new_path_resolved);

#endif

gkfs_rename(const std::string& old_path, const std::string& new_path);

#endif // HAS_RENAME

} // namespace gkfs::syscall



// gkfs_getsingleserverdir is using extern "C" to demangle it for C usage

include/client/rpc/forward_metadata.hpp

+2 −2
Original line number Diff line number Diff line
@@ -57,9 +57,9 @@ forward_stat(const std::string& path, std::string& attr); 


#ifdef HAS_RENAME

int

forward_rename(const std::string& path, const std::string& path2,

forward_rename(const std::string& oldpath, const std::string& newpath,

               const gkfs::metadata::Metadata& md);

#endif

#endif // HAS_RENAME



int

forward_remove(const std::string& path);

include/common/metadata.hpp

+2 −2
Original line number Diff line number Diff line
@@ -143,9 +143,9 @@ public: 


    void

    rename_path(const std::string& rename_path);

#endif

#endif // HAS_RENAME



#endif

#endif // HAS_SYMLINKS

};



} // namespace gkfs::metadata

include/config.hpp

+1 −1
Original line number Diff line number Diff line
@@ -71,7 +71,7 @@ constexpr auto use_link_cnt = false; 
constexpr auto use_blocks = true;

#else

constexpr auto use_blocks = false;

#endif

#endif // HAS_RENAME

/*

 * If true, all chunks on the same host are removed during a metadata remove

 * rpc. This is a technical optimization that reduces the number of RPCs for