Commit 18b42a16 authored by Ramon Nou's avatar Ramon Nou
Browse files

Resolve "Readlink return ENOTSUP"

parent 651e2c18

CHANGELOG.md

+2 −1
Original line number Diff line number Diff line
@@ -12,6 +12,7 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). 
### Changed 

  - Tests check ret for -1 instead of 10000 fd ([!320](https://storage.bsc.es/gitlab/hpc/gekkofs/-/merge_requests/320))

    - Allow some more script tests to run as pthread_at_fork solved some issues.

  - Return EINVAL is better than ENOTSUP on internal readlink ([!223](https://storage.bsc.es/gitlab/hpc/gekkofs/-/merge_requests/223))

  

### Fixed

src/client/hooks.cpp

+1 −2
Original line number Diff line number Diff line
@@ -801,8 +801,7 @@ hook_readlinkat(int dirfd, const char* cpath, char* buf, int bufsiz) { 
            return -ENOTDIR;



        case gkfs::preload::RelativizeStatus::internal:

            LOG(WARNING, "{}() not supported", __func__);

            return -ENOTSUP;

            return -EINVAL;



        default:

            LOG(ERROR, "{}() relativize status unknown: {}", __func__);

tests/integration/harness/gkfs.io/syscall_coverage.cpp

+1 −1
Original line number Diff line number Diff line
@@ -314,7 +314,7 @@ syscall_coverage_exec(const syscall_coverage_options& opts) { 


    // readlinkat

    rv = ::readlinkat(AT_FDCWD, opts.pathname.c_str(), buf, sizeof(buf));

    if(errno != ENOTSUP) {

    if(errno != EINVAL) {

        output("readlinkat", rv, opts);

        return;

    }