Verified Commit b4595662 authored by Alberto Miranda's avatar Alberto Miranda ♨️
Browse files

Fix UB in va_start with argument undergoing default promotion 

For more information refer to:

https://wiki.sei.cmu.edu/confluence/display/cplusplus/EXP58-CPP.+Pass+an+object+of+the+correct+type+to+va_start
parent db21eb06

src/lib/c_wrapper.cpp

+2 −2
Original line number Diff line number Diff line
@@ -309,7 +309,7 @@ ADM_define_data_operation(ADM_server_t server, ADM_job_t job, const char* path, 
ADM_return_t

ADM_connect_data_operation(ADM_server_t server, ADM_job_t job,

                           ADM_dataset_t input, ADM_dataset_t output,

                           bool should_stream, ...) {

                           int should_stream, ...) {



    const scord::server srv{server};
@@ -336,7 +336,7 @@ ADM_finalize_data_operation(ADM_server_t server, ADM_job_t job, 
ADM_return_t

ADM_link_transfer_to_data_operation(ADM_server_t server, ADM_job_t job,

                                    ADM_data_operation_t op,

                                    ADM_transfer_t transfer, bool should_stream,

                                    ADM_transfer_t transfer, int should_stream,

                                    ...) {



    const scord::server srv{server};

src/lib/scord/scord.h

+2 −2
Original line number Diff line number Diff line
@@ -401,7 +401,7 @@ ADM_define_data_operation(ADM_server_t server, ADM_job_t job, const char* path, 
ADM_return_t

ADM_connect_data_operation(ADM_server_t server, ADM_job_t job,

                           ADM_dataset_t input, ADM_dataset_t output,

                           bool should_stream, ...);

                           int should_stream, ...);





/**
@@ -441,7 +441,7 @@ ADM_finalize_data_operation(ADM_server_t server, ADM_job_t job, 
ADM_return_t

ADM_link_transfer_to_data_operation(ADM_server_t server, ADM_job_t job,

                                    ADM_data_operation_t op,

                                    ADM_transfer_t transfer, bool should_stream,

                                    ADM_transfer_t transfer, int should_stream,

                                    ...);