Verified Commit b2f6ed63 authored by Alberto Miranda's avatar Alberto Miranda ♨️
Browse files

Fix return for ADM_update_job()

parent e253e582

examples/cxx/ADM_update_job.cpp

+1 −2
Original line number Diff line number Diff line
@@ -65,8 +65,7 @@ main(int argc, char* argv[]) { 
        [[maybe_unused]] const auto job = admire::register_job(

                server, admire::job::resources{job_nodes}, reqs, 0);



        [[maybe_unused]] ADM_return_t ret = admire::update_job(

                server, job, admire::job::resources{new_job_nodes});

        admire::update_job(server, job, admire::job::resources{new_job_nodes});



        fmt::print(

                stdout,

src/lib/admire.cpp

+8 −2
Original line number Diff line number Diff line
@@ -221,10 +221,16 @@ register_job(const server& srv, const job::resources& resources, 
    return rv.value();

}



admire::error_code

void

update_job(const server& srv, const job& job,

           const job::resources& job_resources) {

    return detail::update_job(srv, job, job_resources);



    const auto ec = detail::update_job(srv, job, job_resources);



    if(!ec) {

        throw std::runtime_error(

                fmt::format("ADM_update_job() error: {}", ec.message()));

    }

}



admire::error_code

src/lib/admire.hpp

+1 −1
Original line number Diff line number Diff line
@@ -51,7 +51,7 @@ admire::job 
register_job(const server& srv, const job::resources& job_resources,

             const job_requirements& reqs, admire::slurm_job_id slurm_id);



admire::error_code

void

update_job(const server& srv, const job&, const job::resources& job_resources);



admire::error_code

src/lib/c_wrapper.cpp

+2 −2
Original line number Diff line number Diff line
@@ -68,7 +68,7 @@ ADM_update_job(ADM_server_t server, ADM_job_t job, 


    const admire::server srv{server};



    return admire::update_job(srv, admire::job{job},

    return admire::detail::update_job(srv, admire::job{job},

                                      admire::job::resources{job_resources});

}