Verified Commit 765ac4a7 authored by Tommaso Tocci's avatar Tommaso Tocci
Browse files

Avoid const on return by value

parent 7fe603ce

ifs/include/daemon/backend/metadata/merge.hpp

+4 −4
Original line number Diff line number Diff line
@@ -23,7 +23,7 @@ class MergeOperand { 
    protected:

        std::string serialize_id() const;

        virtual std::string serialize_params() const = 0;

        virtual const OperandID id() const = 0;

        virtual OperandID id() const = 0;

};



class IncreaseSizeOperand: public MergeOperand {
@@ -38,7 +38,7 @@ class IncreaseSizeOperand: public MergeOperand { 
        IncreaseSizeOperand(const size_t size, const bool append);

        IncreaseSizeOperand(const rdb::Slice& serialized_op);



        const OperandID id() const override;

        OperandID id() const override;

        std::string serialize_params() const override;

};
@@ -49,7 +49,7 @@ class DecreaseSizeOperand: public MergeOperand { 
        DecreaseSizeOperand(const size_t size);

        DecreaseSizeOperand(const rdb::Slice& serialized_op);



        const OperandID id() const override;

        OperandID id() const override;

        std::string serialize_params() const override;

};
@@ -58,7 +58,7 @@ class CreateOperand: public MergeOperand { 
        std::string metadata;

        CreateOperand(const std::string& metadata);



        const OperandID id() const override;

        OperandID id() const override;

        std::string serialize_params() const override;

};

ifs/include/preload/open_file_map.hpp

+1 −1
Original line number Diff line number Diff line
@@ -51,7 +51,7 @@ public: 


    void pos(off64_t pos_);



    const bool get_flag(OpenFile_flags flag);

    bool get_flag(OpenFile_flags flag);



    void set_flag(OpenFile_flags flag, bool value);

ifs/src/daemon/backend/metadata/merge.cpp

+3 −3
Original line number Diff line number Diff line
@@ -44,7 +44,7 @@ IncreaseSizeOperand::IncreaseSizeOperand(const rdb::Slice& serialized_op){ 
    assert(chrs_parsed + 1 == serialized_op.size());

}



const OperandID IncreaseSizeOperand::id() const {

OperandID IncreaseSizeOperand::id() const {

    return OperandID::increase_size;

}
@@ -71,7 +71,7 @@ DecreaseSizeOperand::DecreaseSizeOperand(const rdb::Slice& serialized_op){ 
    assert(read == serialized_op.size());

}



const OperandID DecreaseSizeOperand::id() const {

OperandID DecreaseSizeOperand::id() const {

    return OperandID::decrease_size;

}
@@ -82,7 +82,7 @@ std::string DecreaseSizeOperand::serialize_params() const { 


CreateOperand::CreateOperand(const std::string& metadata): metadata(metadata) {}



const OperandID CreateOperand::id() const{

OperandID CreateOperand::id() const{

    return OperandID::create;

}

ifs/src/preload/open_file_map.cpp

+1 −1
Original line number Diff line number Diff line
@@ -52,7 +52,7 @@ void OpenFile::pos(off64_t pos_) { 
    OpenFile::pos_ = pos_;

}



const bool OpenFile::get_flag(OpenFile_flags flag) {

bool OpenFile::get_flag(OpenFile_flags flag) {

    lock_guard<mutex> lock(pos_mutex_);

    return flags_[to_underlying(flag)];

}