Commit 1079419e authored by David Auer's avatar David Auer
Browse files

Reformat TODOs

parent c1cf3760

src/daemon/handler/srv_management.cpp

+2 −2
Original line number Diff line number Diff line
@@ -61,7 +61,7 @@ rpc_srv_get_fs_config(hg_handle_t handle) { 


hg_return_t

rpc_srv_relocation_start(hg_handle_t handle) {

    cout << "TODO relocation start received\n";

    cout << "TODO(dauer) relocation start received\n";

    rpc_relocation_start_in_t in{};

    rpc_err_out_t out{};

    // out.err = EIO;
@@ -79,7 +79,7 @@ rpc_srv_relocation_start(hg_handle_t handle) { 


    gkfs::relocation::transmit_metadata(host_id);



    out.err = 0; // TODO

    out.err = 0; // TODO(dauer)

    return gkfs::rpc::cleanup_respond(&handle, &in, &out);

}

src/daemon/handler/srv_relocation.cpp

+2 −2
Original line number Diff line number Diff line
@@ -51,12 +51,12 @@ rpc_srv_relocate_metadata(hg_handle_t handle) { 
        return gkfs::rpc::cleanup_respond(&handle, &in, &out);

    }



    cout << fmt::format("TODO Received metadata entry {}: {}\n", in.key,

    cout << fmt::format("TODO(dauer) Received metadata entry {}: {}\n", in.key,

                        in.value);



    GKFS_DATA->mdb()->put(in.key, in.value);



    out.err = 0; // TODO

    out.err = 0; // TODO(dauer)

    return gkfs::rpc::cleanup_respond(&handle, &in, &out);

}

src/daemon/relocation/config_manager.cpp

+3 −2
Original line number Diff line number Diff line
@@ -78,7 +78,8 @@ test_d2d_rpc() { 
        hg_addr_t host_addr;

        rpc_relocation_start_in_t in{};

        rpc_err_out_t out{};

        in.host_id = host_counter; // TODO is this consistent with client?

        in.host_id =

                host_counter; // TODO(dauer) is this consistent with client?

        auto ret = margo_addr_lookup(mid, host.second.c_str(), &host_addr);

        assert(ret == HG_SUCCESS);
@@ -93,7 +94,7 @@ test_d2d_rpc() { 
        ret = margo_get_output(handle, &out);

        assert(ret == HG_SUCCESS);



        // TODO process output

        // TODO(dauer) process output



        ret = margo_free_output(handle, &out);

        assert(ret == HG_SUCCESS);

src/daemon/relocation/transmitter.cpp

+4 −2
Original line number Diff line number Diff line
@@ -30,6 +30,7 @@ namespace gkfs::relocation { 


void

transmit_metadata(gkfs::rpc::host_t localhost) {

    // TODO(dauer) rename me

    auto hosts = read_hosts_file();



    gkfs::rpc::SimpleHashDistributor distributor(localhost, hosts.size());
@@ -39,11 +40,12 @@ transmit_metadata(gkfs::rpc::host_t localhost) { 
            margo_init(GKFS_DATA->bind_addr().c_str(), MARGO_CLIENT_MODE, 0, 0);

    assert(mid);





    hg_id_t relocate_metadata_id = MARGO_REGISTER(

            mid, gkfs::rpc::tag::relocate_metadata, rpc_relocate_metadata_in_t,

            rpc_err_out_t, rpc_srv_relocate_metadata);



    // Relocate metadata



    for(auto metadatum : GKFS_DATA->mdb()->get_all()) {

        if(metadatum.first == "/") {

            continue;
@@ -79,7 +81,7 @@ transmit_metadata(gkfs::rpc::host_t localhost) { 
        ret = margo_get_output(handle, &out);

        assert(ret == HG_SUCCESS);



        // TODO process output

        // TODO(dauer) process output

        GKFS_DATA->mdb()->remove(in.key);



        ret = margo_free_output(handle, &out);